[PATCH] Fix frontend crash related to forward declaration of NSNumber

hfinkel at anl.gov hfinkel at anl.gov
Mon Feb 16 05:44:21 PST 2015

In http://reviews.llvm.org/D7643#124251, @AlexDenisov wrote:

> Not to give you a hard time, but, why are you asking for pre-commit review?
>  Well, due to first link (obtaining commit access) I got 'commit-after-approval’ access, so just trying to follow the rules.

Understood, but we do have this rule:

> 2. You are allowed to commit patches without approval which you think are obvious. This is clearly a subjective decision — we simply expect you to use good judgement. Examples include: fixing build breakage, reverting obviously broken patches, documentation/comment changes, any other minor changes.

and you're welcome to follow that one too ;)

> Anyway, thank you for feedback and useful links.


> -- 


> AlexDenisov

>  Software Engineer, https://github.com/AlexDenisov



More information about the cfe-commits mailing list