<html><head><style>body{font-family:Helvetica,Arial;font-size:13px}</style></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px; color: rgba(0,0,0,1.0); margin: 0px; line-height: auto;"><div><blockquote type="cite" class="clean_bq" style="color: rgb(0, 0, 0); font-family: Helvetica, Arial; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">Not to give you a hard time, but, why are you asking for pre-commit review?</blockquote></div><p>Well, due to first link (obtaining commit access) I got 'commit-after-approval’ access, so just trying to follow the rules.</p><p><span style="font-family: helvetica, arial;">Anyway, thank you for feedback and useful links.</span></p><p><span style="font-family: helvetica, arial;">-- </span></p></div><div id="bloop_sign_1424093863498434048" class="bloop_sign"><div style="font-family:helvetica,arial;font-size:13px">AlexDenisov</div><div style="font-family:helvetica,arial;font-size:13px">Software Engineer, <a href="https://github.com/AlexDenisov">https://github.com/AlexDenisov</a></div></div> <br><p style="color:#000;">On 16 Feb 2015 at 14:35:27, hfinkel@anl.gov (<a href="mailto:hfinkel@anl.gov">hfinkel@anl.gov</a>) wrote:</p> <blockquote type="cite" class="clean_bq"><span><div><div></div><div>In http://reviews.llvm.org/D7643#124219, @AlexDenisov wrote:
<br>
<br>> Ping?
<br>>
<br>> It’s a trivial one, but I don’t want to push it without review, though it fixes crash
<br>
<br>
<br>Not to give you a hard time, but, why are you asking for pre-commit review? It sounds like you consider this to be a fairly-obvious one-line change to fix a crash-on-invalid case (and that is indeed what it looks like). If so, you don't need pre-commit review, so please feel free to commit. If you'd like a pre-commit review anyway, it is helpful to explain your doubts so potential reviews have some idea about what you're unsure, and are aware of any potential complications you're contemplating.
<br>
<br>See: http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access
<br>
<br>Also, for the future, please upload full-context patches to Phabricator, see: http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
<br>
<br>> --
<br>
<br>> AlexDenisov
<br>
<br>> Software Engineer, https://github.com/AlexDenisov
<br>
<br>
<br>
<br>http://reviews.llvm.org/D7643
<br>
<br>EMAIL PREFERENCES
<br> http://reviews.llvm.org/settings/panel/emailpreferences/
<br>
<br>
<br></div></div></span></blockquote></body></html>