r201010 - ASTUnit: remove dead code in remapping files

Daniel Jasper djasper at google.com
Wed Feb 12 00:51:37 PST 2014


I have submitted r201220 to fix this. I hope it is the right fix, at least
it makes all the tests pass.


On Wed, Feb 12, 2014 at 9:08 AM, Dmitri Gribenko <gribozavr at gmail.com>wrote:

> On Wed, Feb 12, 2014 at 7:55 AM, Chandler Carruth <chandlerc at google.com>
> wrote:
> >
> > On Tue, Feb 11, 2014 at 11:26 PM, Daniel Jasper <djasper at google.com>
> wrote:
> >>>
> >>> -      OwnedBuffers.push_back(memBuf);
> >>
> >>
> >> Not adding MemoryBuffers to OwnedBuffers creates a memory leak. Did you
> >> intentionally remove that?
> >
> > This can't have been intentional. Introducing leaks isn't OK, I think its
> > fine to either add back the necessary code or in a worst case given that
> > this was just dead code cleanup, revert. Otherwise the leak-checking
> build
> > bots will stay red. =[
>
> Hi Chandler, Daniel,
>
> Sorry for the breakage, I will fix this today.
>
> Dmitri
>
> --
> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140212/05b64915/attachment.html>


More information about the cfe-commits mailing list