r201010 - ASTUnit: remove dead code in remapping files

Dmitri Gribenko gribozavr at gmail.com
Wed Feb 12 00:08:56 PST 2014


On Wed, Feb 12, 2014 at 7:55 AM, Chandler Carruth <chandlerc at google.com> wrote:
>
> On Tue, Feb 11, 2014 at 11:26 PM, Daniel Jasper <djasper at google.com> wrote:
>>>
>>> -      OwnedBuffers.push_back(memBuf);
>>
>>
>> Not adding MemoryBuffers to OwnedBuffers creates a memory leak. Did you
>> intentionally remove that?
>
> This can't have been intentional. Introducing leaks isn't OK, I think its
> fine to either add back the necessary code or in a worst case given that
> this was just dead code cleanup, revert. Otherwise the leak-checking build
> bots will stay red. =[

Hi Chandler, Daniel,

Sorry for the breakage, I will fix this today.

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/



More information about the cfe-commits mailing list