r201010 - ASTUnit: remove dead code in remapping files

Chandler Carruth chandlerc at google.com
Tue Feb 11 23:55:30 PST 2014


On Tue, Feb 11, 2014 at 11:26 PM, Daniel Jasper <djasper at google.com> wrote:

> -      OwnedBuffers.push_back(memBuf);
>
>
> Not adding MemoryBuffers to OwnedBuffers creates a memory leak. Did you
> intentionally remove that?
>

This can't have been intentional. Introducing leaks isn't OK, I think its
fine to either add back the necessary code or in a worst case given that
this was just dead code cleanup, revert. Otherwise the leak-checking build
bots will stay red. =[
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140211/083528ba/attachment.html>


More information about the cfe-commits mailing list