r184941 - Quieting an MSVC warning about converting negative integer constants to unsigned types.

Aaron Ballman aaron at aaronballman.com
Wed Jun 26 09:25:43 PDT 2013


On Wed, Jun 26, 2013 at 12:22 PM, David Blaikie <dblaikie at gmail.com> wrote:
>
> On Jun 26, 2013 5:58 AM, "Aaron Ballman" <aaron at aaronballman.com> wrote:
>>
>> Author: aaronballman
>> Date: Wed Jun 26 07:54:49 2013
>> New Revision: 184941
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=184941&view=rev
>> Log:
>> Quieting an MSVC warning about converting negative integer constants to
>> unsigned types.
>
> Looks like a broken warning, unless I'm missing something in the below code
> (quite possible). Should we just turn it off?

The warning is kind of broken IMO (in some circumstances), but it
could still catch the occasional bug and doesn't affect us too often
in practice.

~Aaron



More information about the cfe-commits mailing list