r184941 - Quieting an MSVC warning about converting negative integer constants to unsigned types.

[David Blaikie]

On Jun 26, 2013 9:25 AM, "Aaron Ballman" <aaron at aaronballman.com> wrote:
>
> On Wed, Jun 26, 2013 at 12:22 PM, David Blaikie <dblaikie at gmail.com>
wrote:
> >
> > On Jun 26, 2013 5:58 AM, "Aaron Ballman" <aaron at aaronballman.com> wrote:
> >>
> >> Author: aaronballman
> >> Date: Wed Jun 26 07:54:49 2013
> >> New Revision: 184941
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=184941&view=rev
> >> Log:
> >> Quieting an MSVC warning about converting negative integer constants to
> >> unsigned types.
> >
> > Looks like a broken warning, unless I'm missing something in the below
code
> > (quite possible). Should we just turn it off?
>
> The warning is kind of broken IMO (in some circumstances), but it
> could still catch the occasional bug and doesn't affect us too often
> in practice.

Yeah, I don't feel too strongly but our usual approach is to suppress such
warnings in other compilers and if there's value, add them to clang
(possibly with any tweaks/improvements they need to meet our standards)

>
> ~Aaron
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130626/36ceb7cd/attachment.html>