r184941 - Quieting an MSVC warning about converting negative integer constants to unsigned types.

[David Blaikie]

On Jun 26, 2013 5:58 AM, "Aaron Ballman" <aaron at aaronballman.com> wrote:
>
> Author: aaronballman
> Date: Wed Jun 26 07:54:49 2013
> New Revision: 184941
>
> URL: http://llvm.org/viewvc/llvm-project?rev=184941&view=rev
> Log:
> Quieting an MSVC warning about converting negative integer constants to
unsigned types.

Looks like a broken warning, unless I'm missing something in the below code
(quite possible). Should we just turn it off?

>
> Modified:
>     cfe/trunk/include/clang/AST/Comment.h
>
> Modified: cfe/trunk/include/clang/AST/Comment.h
> URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/Comment.h?rev=184941&r1=184940&r2=184941&view=diff
>
==============================================================================
> --- cfe/trunk/include/clang/AST/Comment.h (original)
> +++ cfe/trunk/include/clang/AST/Comment.h Wed Jun 26 07:54:49 2013
> @@ -701,7 +701,7 @@ private:
>  public:
>    enum {
>      InvalidParamIndex = ~0U,
> -    VarArgParamIndex = InvalidParamIndex - 1U
> +    VarArgParamIndex = ~0U/*InvalidParamIndex*/ - 1U
>    };
>
>    ParamCommandComment(SourceLocation LocBegin,
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130626/0c125d24/attachment.html>