[cfe-commits] [PATCH] - need approval - PPC and PS3 target changes
clattner at apple.com
Tue Jun 22 22:23:03 PDT 2010
On Jun 22, 2010, at 2:41 PM, John Thompson wrote:
> The enclosed patch contains three changes:
> 1. In compiling the afore-mentioned code targeting PS3, I ran into the lack of some needed implicit defines.
> 2. Changes to the PS3 target class to fix some sizes of things. Curiously, the PS3 thinks it's a PowerPC64, though it's configuration seems to actually be more like PowerPC32.
> 3. Added some PPC-specific constraints, based on the gcc docs. I just guessed at what the actions should be. This is to fix some code I'm trying to compiler which uses at least the Z constraint.
> With your permission I will check it in. Previously I was given permission to mess with the PS3 stuff, but because the constraint thing affects the PowerPC, I thought I should ask.
This looks ok to me, except for:
+ case 'wd':// VSX vector register to hold vector double data
+ case 'wf':// VSX vector register to hold vector float data
+ case 'ws':// VSX vector register to hold scalar float data
+ case 'wa':// Any VSX register
That's probably not doing what you think it's doing...
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits