<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jun 22, 2010, at 2:41 PM, John Thompson wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>The enclosed patch contains three changes:</div>
<div> </div>
<div>1. In compiling the afore-mentioned code targeting PS3, I ran into the lack of some needed implicit defines.<br clear="all"></div>
<div>2. Changes to the PS3 target class to fix some sizes of things. Curiously, the PS3 thinks it's a PowerPC64, though it's configuration seems to actually be more like PowerPC32.</div>
<div> </div>
<div>3. Added some PPC-specific constraints, based on the gcc docs. I just guessed at what the actions should be. This is to fix some code I'm trying to compiler which uses at least the Z constraint.</div>
<div> </div>
<div>With your permission I will check it in. Previously I was given permission to mess with the PS3 stuff, but because the constraint thing affects the PowerPC, I thought I should ask.</div>
<div> </div></blockquote><br></div><div>This looks ok to me, except for:</div><div><br></div><div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 12px/normal Inconsolata; ">+ case 'wd':// VSX vector register to hold vector double data </div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 12px/normal Inconsolata; ">+ case 'wf':// VSX vector register to hold vector float data </div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 12px/normal Inconsolata; ">+ case 'ws':// VSX vector register to hold scalar float data </div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 12px/normal Inconsolata; ">+ case 'wa':// Any VSX register </div><div><font class="Apple-style-span" face="Inconsolata"><br></font></div><div><font class="Apple-style-span" face="Inconsolata"><br></font></div><div><font class="Apple-style-span" face="Inconsolata">That's probably not doing what you think it's doing...</font></div><div><font class="Apple-style-span" face="Inconsolata"><br></font></div><div><font class="Apple-style-span" face="Inconsolata">-Chris</font></div></div><br></body></html>