[cfe-commits] [PATCH] - need approval - PPC and PS3 target changes

John Thompson john.thompson.jtsoftware at gmail.com
Wed Jun 23 14:16:08 PDT 2010

Oh right, I didn't even notice the double character constants.

Here's another whack it.  Since the function is passed a reference to the
string pointer, it seems I can bump it.  It this an acceptable side effect?

Thanks for looking it.


On Tue, Jun 22, 2010 at 10:23 PM, Chris Lattner <clattner at apple.com> wrote:

>  On Jun 22, 2010, at 2:41 PM, John Thompson wrote:
>  The enclosed patch contains three changes:
> 1.  In compiling the afore-mentioned code targeting PS3, I ran into the
> lack of some needed implicit defines.
> 2. Changes to the PS3 target class to fix some sizes of things.  Curiously,
> the PS3 thinks it's a PowerPC64, though it's configuration seems to actually
> be more like PowerPC32.
> 3. Added some PPC-specific constraints, based on the gcc docs.  I just
> guessed at what the actions should be.  This is to fix some code I'm trying
> to compiler which uses at least the Z constraint.
> With your permission I will check it in.  Previously I was given permission
> to mess with the PS3 stuff, but because the constraint thing affects the
> PowerPC, I thought I should ask.
> This looks ok to me, except for:
>  +    case 'wd':// VSX vector register to hold vector double data
> +    case 'wf':// VSX vector register to hold vector float data
> +    case 'ws':// VSX vector register to hold scalar float data
> +    case 'wa':// Any VSX register
> That's probably not doing what you think it's doing...
> -Chris

John Thompson
John.Thompson.JTSoftware at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20100623/0b6cedf4/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PpcAndPpuTargetStuff1.patch
Type: application/octet-stream
Size: 5378 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20100623/0b6cedf4/attachment.obj>

More information about the cfe-commits mailing list