[vmkit-commits] [vmkit] r119039 - in /vmkit/trunk: include/mvm/Threads/Thread.h lib/J3/Compiler/JavaJIT.cpp lib/J3/LLVMRuntime/runtime-default.ll

[Gaël Thomas]

Hi!

2010/11/14 nicolas geoffray <nicolas.geoffray at gmail.com>:
> Hi Gael!
> Inlined comments.
>
> On Sun, Nov 14, 2010 at 1:33 PM, Gael Thomas <gael.thomas at lip6.fr> wrote:
>>
>>   /// doYield - Flag to tell the thread to yield for GC reasons.
>>   ///
>> -  bool doYield;
>> +  char doYield;
>
> Please use uint8_t instead of char.
Ok :)

>>
>> +
>> +  /// vmData - vm specific data
>> +  ///
>> +  void* vmData;
>
> There is already a MyVM to hold the virtual machine, why another one?
I want a thread specific data!

>
>>
>>   /// inRV - Flag to tell that the thread is being part of a rendezvous.
>>   ///
>> -  bool inRV;
>> +  char inRV;
>>
>
> char -> uint8_t
Ok

>
>>
>>   /// joinedRV - Flag to tell that the thread has joined a rendezvous.
>>   ///
>> -  bool joinedRV;
>> +  char joinedRV;
>
> char - >uint8_t
Ok

Gaël

> _______________________________________________
> vmkit-commits mailing list
> vmkit-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/vmkit-commits
>
>



-- 
-------------------------------------------------------------------------------------------------
Gaël Thomas, Associate Professor,
University of Pierre and Marie Curie
Boite courrier 169, 217 - 26-00, REGAL Team, INRIA/LIP6,
4, place Jussieu, Paris F-75005
Web: http://pagesperso-systeme.lip6.fr/Gael.Thomas/
Phone (mob): +33 6 10 39 31 17           Fax : +33 1 44 27 70 00
-------------------------------------------------------------------------------------------------