[vmkit-commits] [vmkit] r119039 - in /vmkit/trunk: include/mvm/Threads/Thread.h lib/J3/Compiler/JavaJIT.cpp lib/J3/LLVMRuntime/runtime-default.ll

[nicolas geoffray]

Hi Gael!

Inlined comments.

On Sun, Nov 14, 2010 at 1:33 PM, Gael Thomas <gael.thomas at lip6.fr> wrote:
>
>   /// doYield - Flag to tell the thread to yield for GC reasons.
>   ///
> -  bool doYield;
> +  char doYield;
>

Please use uint8_t instead of char.

+
> +  /// vmData - vm specific data
> +  ///
> +  void* vmData;
>

There is already a MyVM to hold the virtual machine, why another one?


>
>   /// inRV - Flag to tell that the thread is being part of a rendezvous.
>   ///
> -  bool inRV;
> +  char inRV;
>
>
char -> uint8_t


>   /// joinedRV - Flag to tell that the thread has joined a rendezvous.
>   ///
> -  bool joinedRV;
> +  char joinedRV;
>

char - >uint8_t
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/vmkit-commits/attachments/20101114/f17d07c1/attachment.html>