[Parallel_libs-commits] [PATCH] D27941: [Axccel] Remove -Wno-missing-braces in build

[Jason Henline via Phabricator via Parallel_libs-commits]

jhen created this revision.
jhen added a reviewer: jlebar.
jhen added a subscriber: parallel_libs-commits.
Herald added a subscriber: mgorny.

I originally added the -Wno-missing-braces flag because I thought it was
erroneously flagging std::array initializations. Now I realize the extra
braces really are desired for these initializations, so I'm turning the
warning flag back on.


https://reviews.llvm.org/D27941

Files:
  acxxel/CMakeLists.txt
  acxxel/examples/opencl_example.cpp
  acxxel/tests/span_test.cpp


Index: acxxel/tests/span_test.cpp
===================================================================
--- acxxel/tests/span_test.cpp
+++ acxxel/tests/span_test.cpp
@@ -79,12 +79,12 @@
 }
 
 TEST(Span, StdArrayConstruction) {
-  std::array<int, 3> Array{0, 1, 2};
+  std::array<int, 3> Array{{0, 1, 2}};
   acxxel::Span<int> Span(Array);
   EXPECT_EQ(Span.data(), Array.data());
   EXPECT_EQ(static_cast<size_t>(Span.size()), Array.size());
 
-  std::array<const int, 3> ConstArray{0, 1, 2};
+  std::array<const int, 3> ConstArray{{0, 1, 2}};
   acxxel::Span<const int> ConstSpan(ConstArray);
   EXPECT_EQ(ConstSpan.data(), ConstArray.data());
   EXPECT_EQ(static_cast<size_t>(ConstSpan.size()), ConstArray.size());
Index: acxxel/examples/opencl_example.cpp
===================================================================
--- acxxel/examples/opencl_example.cpp
+++ acxxel/examples/opencl_example.cpp
@@ -57,9 +57,9 @@
 
 int main() {
   float A = 2.f;
-  std::array<float, 3> X = {0.f, 1.f, 2.f};
-  std::array<float, 3> Y = {3.f, 4.f, 5.f};
-  std::array<float, 3> Expected = {3.f, 6.f, 9.f};
+  std::array<float, 3> X{{0.f, 1.f, 2.f}};
+  std::array<float, 3> Y{{3.f, 4.f, 5.f}};
+  std::array<float, 3> Expected{{3.f, 6.f, 9.f}};
   saxpy(A, X, Y);
   for (int I = 0; I < 3; ++I)
     if (X[I] != Expected[I]) {
Index: acxxel/CMakeLists.txt
===================================================================
--- acxxel/CMakeLists.txt
+++ acxxel/CMakeLists.txt
@@ -35,7 +35,7 @@
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
 
 # Add warning flags.
-set(CMAKE_CXX_FLAGS  "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wno-missing-braces")
+set(CMAKE_CXX_FLAGS  "${CMAKE_CXX_FLAGS} -Wall -Wextra")
 
 add_library(
     acxxel


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27941.81996.patch
Type: text/x-patch
Size: 1710 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/parallel_libs-commits/attachments/20161219/3f10d26d/attachment.bin>