[Parallel_libs-commits] [parallel-libs] r290137 - [Axccel] Remove -Wno-missing-braces in build

[Jason Henline via Parallel_libs-commits]

Author: jhen
Date: Mon Dec 19 15:34:07 2016
New Revision: 290137

URL: http://llvm.org/viewvc/llvm-project?rev=290137&view=rev
Log:
[Axccel] Remove -Wno-missing-braces in build

Summary:
I originally added the -Wno-missing-braces flag because I thought it was
erroneously flagging std::array initializations. Now I realize the extra
braces really are desired for these initializations, so I'm turning the
warning flag back on.

Reviewers: jlebar

Subscribers: mgorny, parallel_libs-commits

Differential Revision: https://reviews.llvm.org/D27941

Modified:
    parallel-libs/trunk/acxxel/CMakeLists.txt
    parallel-libs/trunk/acxxel/examples/opencl_example.cpp
    parallel-libs/trunk/acxxel/tests/span_test.cpp

Modified: parallel-libs/trunk/acxxel/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/parallel-libs/trunk/acxxel/CMakeLists.txt?rev=290137&r1=290136&r2=290137&view=diff
==============================================================================
--- parallel-libs/trunk/acxxel/CMakeLists.txt (original)
+++ parallel-libs/trunk/acxxel/CMakeLists.txt Mon Dec 19 15:34:07 2016
@@ -35,7 +35,7 @@ set(CMAKE_CXX_STANDARD 11)
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
 
 # Add warning flags.
-set(CMAKE_CXX_FLAGS  "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wno-missing-braces")
+set(CMAKE_CXX_FLAGS  "${CMAKE_CXX_FLAGS} -Wall -Wextra")
 
 add_library(
     acxxel

Modified: parallel-libs/trunk/acxxel/examples/opencl_example.cpp
URL: http://llvm.org/viewvc/llvm-project/parallel-libs/trunk/acxxel/examples/opencl_example.cpp?rev=290137&r1=290136&r2=290137&view=diff
==============================================================================
--- parallel-libs/trunk/acxxel/examples/opencl_example.cpp (original)
+++ parallel-libs/trunk/acxxel/examples/opencl_example.cpp Mon Dec 19 15:34:07 2016
@@ -57,9 +57,9 @@ void saxpy(float A, std::array<float, N>
 
 int main() {
   float A = 2.f;
-  std::array<float, 3> X = {0.f, 1.f, 2.f};
-  std::array<float, 3> Y = {3.f, 4.f, 5.f};
-  std::array<float, 3> Expected = {3.f, 6.f, 9.f};
+  std::array<float, 3> X{{0.f, 1.f, 2.f}};
+  std::array<float, 3> Y{{3.f, 4.f, 5.f}};
+  std::array<float, 3> Expected{{3.f, 6.f, 9.f}};
   saxpy(A, X, Y);
   for (int I = 0; I < 3; ++I)
     if (X[I] != Expected[I]) {

Modified: parallel-libs/trunk/acxxel/tests/span_test.cpp
URL: http://llvm.org/viewvc/llvm-project/parallel-libs/trunk/acxxel/tests/span_test.cpp?rev=290137&r1=290136&r2=290137&view=diff
==============================================================================
--- parallel-libs/trunk/acxxel/tests/span_test.cpp (original)
+++ parallel-libs/trunk/acxxel/tests/span_test.cpp Mon Dec 19 15:34:07 2016
@@ -79,12 +79,12 @@ TEST(Span, ArrayConstruction) {
 }
 
 TEST(Span, StdArrayConstruction) {
-  std::array<int, 3> Array{0, 1, 2};
+  std::array<int, 3> Array{{0, 1, 2}};
   acxxel::Span<int> Span(Array);
   EXPECT_EQ(Span.data(), Array.data());
   EXPECT_EQ(static_cast<size_t>(Span.size()), Array.size());
 
-  std::array<const int, 3> ConstArray{0, 1, 2};
+  std::array<const int, 3> ConstArray{{0, 1, 2}};
   acxxel::Span<const int> ConstSpan(ConstArray);
   EXPECT_EQ(ConstSpan.data(), ConstArray.data());
   EXPECT_EQ(static_cast<size_t>(ConstSpan.size()), ConstArray.size());