[Parallel_libs-commits] [PATCH] D23577: [StreamExecutor] Executor add synchronous methods

[James Price via Parallel_libs-commits]

jprice added a comment.

Just some mild pedantry from me.


================
Comment at: streamexecutor/include/streamexecutor/Executor.h:199
@@ +198,3 @@
+      return make_error(
+          "array size mismatch for D2H, host source has element count " +
+          llvm::Twine(Src.size()) +
----------------
H2D

================
Comment at: streamexecutor/include/streamexecutor/Executor.h:284
@@ +283,3 @@
+      return make_error(
+          "array size mismatch for D2H, device source has element count " +
+          llvm::Twine(Src.getElementCount()) +
----------------
D2D

================
Comment at: streamexecutor/include/streamexecutor/Stream.h:214
@@ +213,3 @@
+    if (Src.size() != Dst.getElementCount())
+      setError("array size mismatch for D2H, host source has element count " +
+               llvm::Twine(Src.size()) +
----------------
H2D

================
Comment at: streamexecutor/include/streamexecutor/Stream.h:292
@@ +291,3 @@
+    if (Src.getElementCount() != Dst.getElementCount())
+      setError("array size mismatch for D2H, device source has element count " +
+               llvm::Twine(Src.getElementCount()) +
----------------
D2D


https://reviews.llvm.org/D23577