[Parallel_libs-commits] [PATCH] D23577: [StreamExecutor] Executor add synchronous methods

[Jason Henline via Parallel_libs-commits]

jhen added inline comments.

================
Comment at: streamexecutor/include/streamexecutor/Stream.h:111
@@ +110,3 @@
+                        const GlobalDeviceMemory<T> &DeviceSrc,
+                        size_t ElementCount, size_t SrcElementOffset = 0) {
+    if (ElementCount + SrcElementOffset > DeviceSrc.getElementCount())
----------------
jlebar wrote:
> I guess I expected that we'd match the Executor's interface, with the overloads and such.  But maybe you plan to do that in a separate patch?
I was thinking of doing it in a separate patch, but changed my mind. Now these interfaces should be updated too.


https://reviews.llvm.org/D23577