[Parallel_libs-commits] [PATCH] D23333: [StreamExecutor] Add basic Stream operations

[James Price via Parallel_libs-commits]

jprice added a comment.

FWIW, this design feels a lot cleaner to me :-)


================
Comment at: streamexecutor/include/streamexecutor/PlatformInterfaces.h:48
@@ +47,3 @@
+/// the functions in this interface.
+class PlatformStreamExecutor {
+public:
----------------
Missing virtual destructor in this class.

================
Comment at: streamexecutor/include/streamexecutor/PlatformInterfaces.h:60
@@ +59,3 @@
+  /// Destroys the given stream.
+  virtual void deallocateStream(Stream *S) = 0;
+
----------------
Should there be a corresponding platform-specific `allocateStream()`?


https://reviews.llvm.org/D23333