[Parallel_libs-commits] [PATCH] D23333: [StreamExecutor] Add basic Stream operations

[Jason Henline via Parallel_libs-commits]

jhen added a comment.

This version gets rid of the StreamParent because it was obscuring the logic about which functions are overridden by each platform. I renamed the file Interfaces.h to PlatformInterfaces.h to try to clarify its purpose as the interfaces that each platform must implement. I also added the `PlatformStreamExecutor` interface class in PlatformInterfaces.h, and that class takes the place of what StreamParent was trying to do.

Thanks to jlebar for talking this over with me offline to try to get the design right.


================
Comment at: streamexecutor/include/streamexecutor/Stream.h:64
@@ +63,3 @@
+public:
+  Stream(StreamParent *Parent);
+
----------------
jlebar wrote:
> explicit?
It wasn't meant to be and it's not anymore.

================
Comment at: streamexecutor/lib/Stream.cpp:51
@@ +50,3 @@
+  return *this;
+}
+
----------------
jlebar wrote:
> I wonder if we need any of these `*raw*` functions anymore, now that they're just forwarding to the parent.
I got rid of them for now, but I might bring them back later if users need to include Stream.h and I don't want them to see the PlatformInterface.h file.


https://reviews.llvm.org/D23333