[Openmp-dev] Patch for PPC64LE architecture

[Carlo Bertolli]

Hi,

Thanks for the suggestion - I actually like it.

Yes, the plan was:

1. If something is common between BE and LE PPC64 archs, then I would use
KMP_ARCH_PPC64 || KMP_ARCH_PPC64LE.

2. If something only applies to PPC64 BE, then I would use  KMP_ARCH_PPC64.

3. If something only applies to PPC64 LE, then I would use
KMP_ARCH_PPC64LE.

If you feel like this is something critical, I will produce a new patch
with the *BE and *LE macros. Otherwise, I will add it in the next patch I
am going to produce.


Thanks

-- Carlo




From:	C Bergström <cbergstrom at pathscale.com>
To:	Carlo Bertolli/Watson/IBM at IBMUS
Cc:	"openmp-dev at dcs-maillist2.engr.illinois.edu"
            <openmp-dev at dcs-maillist2.engr.illinois.edu>
Date:	10/23/2014 02:33 AM
Subject:	Re: [Openmp-dev] Patch for PPC64LE architecture





On Thu, Oct 23, 2014 at 9:50 AM, Carlo Bertolli <cbertol at us.ibm.com> wrote:
  Hi all

  The following patch is to support the PPC64LE (little endian)
  architecture.

  Please note that in the source code I distinguished the two architectures
  with two different macros (KMP_ARCH_PPC64 and KMP_ARCH_PPC64LE).
  However, the two macros are currently always used together and the
  compilation path is precisely the same.
  I did this because I wanted to make sure that in the future we are able
  to distinguish them.


  Please let me know your thoughts.



I don't think this is super important, but I would have done the following

KMP_ARCH_PPC64 == Things shared for both BE and LE
KMP_ARCH_PPC64BE == BE specific
KMP_ARCH_PPC64LE == LE specific

Currently in the patch I think you're using KMP_ARCH_PPC64 to mean BE, but
in the future if anything is common to both of them will you just use
KMP_ARCH_PPC64 || KMP_ARCH_PPC64LE or what's the plan? (They can't always
be mutually exclusive - can they?)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/openmp-dev/attachments/20141023/89adf61f/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: graycol.gif
Type: image/gif
Size: 105 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-dev/attachments/20141023/89adf61f/attachment.gif>