[Openmp-dev] Getting Architecture Patch

[C Bergström]

3 nits

1) I think you can change it to #warn and avoid the compiler failure
(please see what others are doing with similar approach and let me know).
There's also possibility of actually linking and doing a printf which would
avoid the whole regex mess.. Is there a strong reason for #error? (maybe
faster?)

2) Would anyone @Intel strongly oppose a global rename of 32e to something
which is more commonly used (x86_64, amd64 /* joking */ or x8664)

3) Can you include ARM64

Thanks

On Thu, Dec 18, 2014 at 1:53 AM, Carlo Bertolli <cbertol at us.ibm.com> wrote:
>
> Hi Johnny
>
>
> Thanks for this patch. I will give it a try on our machines and let you
> know.
>
>
> Cheers
>
> -- Carlo
>
>
> [image: Inactive hide details for "Peyton, Jonathan L" ---12/17/2014
> 01:18:14 PM---Due to recent aarch64 and ppc64le port patches that]"Peyton,
> Jonathan L" ---12/17/2014 01:18:14 PM---Due to recent aarch64 and ppc64le
> port patches that have been sent, I have finished up this bit of c
>
> From: "Peyton, Jonathan L" <jonathan.l.peyton at intel.com>
> To: "openmp-dev at dcs-maillist2.engr.illinois.edu" <
> openmp-dev at dcs-maillist2.engr.illinois.edu>
> Cc: Carlo Bertolli/Watson/IBM at IBMUS, C Bergström <cbergstrom at pathscale.com
> >
> Date: 12/17/2014 01:18 PM
> Subject: Getting Architecture Patch
> ------------------------------
>
>
>
> Due to recent aarch64 and ppc64le port patches that have been sent, I have
> finished up this bit of code for CMake which detects the architecture by
> probing the compiler.
>
> Carlo and C. Bergström can you two look at this patch and see if it
> adequately solves the detecting architecture problem for you both and add
> the proper macro into the GetArchitecture.cmake (this will make sense once
> you look at the patch)?  I would like this to be committed before either
> port so both ports can use this new patch.
>
> -- Johnny
>  [attachment "cmake_get_arch.patch" deleted by Carlo Bertolli/Watson/IBM]
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/openmp-dev/attachments/20141218/29c56473/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: graycol.gif
Type: image/gif
Size: 105 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-dev/attachments/20141218/29c56473/attachment.gif>