<div dir="ltr">3 nits<div><br></div><div>1) I think you can change it to #warn and avoid the compiler failure (please see what others are doing with similar approach and let me know). There's also possibility of actually linking and doing a printf which would avoid the whole regex mess.. Is there a strong reason for #error? (maybe faster?)</div><div><br></div><div>2) Would anyone @Intel strongly oppose a global rename of 32e to something which is more commonly used (x86_64, amd64 /* joking */ or x8664)</div><div><br></div><div>3) Can you include ARM64</div><div><br></div><div>Thanks</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 18, 2014 at 1:53 AM, Carlo Bertolli <span dir="ltr"><<a href="mailto:cbertol@us.ibm.com" target="_blank">cbertol@us.ibm.com</a>></span> wrote:<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>
<p><font face="sans-serif">Hi Johnny</font><br>
<br>
<br>
<font face="sans-serif">Thanks for this patch. I will give it a try on our machines and let you know.</font><br>
<br>
<br>
<font face="sans-serif">Cheers</font><br>
<br>
<font face="sans-serif">-- Carlo</font><br>
<br>
<br>
<img width="16" height="16" src="cid:1__=0ABBF721DF87335E8f9e8a93df938@us.ibm.com" border="0" alt="Inactive hide details for "Peyton, Jonathan L" ---12/17/2014 01:18:14 PM---Due to recent aarch64 and ppc64le port patches that "><font color="#424282" face="sans-serif">"Peyton, Jonathan L" ---12/17/2014 01:18:14 PM---Due to recent aarch64 and ppc64le port patches that have been sent, I have finished up this bit of c</font><br>
<br>
<font size="1" color="#5F5F5F" face="sans-serif">From: </font><font size="1" face="sans-serif">"Peyton, Jonathan L" <<a href="mailto:jonathan.l.peyton@intel.com" target="_blank">jonathan.l.peyton@intel.com</a>></font><br>
<font size="1" color="#5F5F5F" face="sans-serif">To: </font><font size="1" face="sans-serif">"<a href="mailto:openmp-dev@dcs-maillist2.engr.illinois.edu" target="_blank">openmp-dev@dcs-maillist2.engr.illinois.edu</a>" <<a href="mailto:openmp-dev@dcs-maillist2.engr.illinois.edu" target="_blank">openmp-dev@dcs-maillist2.engr.illinois.edu</a>></font><br>
<font size="1" color="#5F5F5F" face="sans-serif">Cc: </font><font size="1" face="sans-serif">Carlo Bertolli/Watson/IBM@IBMUS, C Bergström <<a href="mailto:cbergstrom@pathscale.com" target="_blank">cbergstrom@pathscale.com</a>></font><br>
<font size="1" color="#5F5F5F" face="sans-serif">Date: </font><font size="1" face="sans-serif">12/17/2014 01:18 PM</font><br>
<font size="1" color="#5F5F5F" face="sans-serif">Subject: </font><font size="1" face="sans-serif">Getting Architecture Patch</font><br>
</p><hr width="100%" size="2" align="left" noshade style="color:#8091a5"><span class=""><br>
<br>
<br>
<font face="Calibri">Due to recent aarch64 and ppc64le port patches that have been sent, I have finished up this bit of code for CMake which detects the architecture by probing the compiler.</font><br>
<font face="Calibri"> </font><br>
<font face="Calibri">Carlo and C. Bergström can you two look at this patch and see if it adequately solves the detecting architecture problem for you both and add the proper macro into the GetArchitecture.cmake (this will make sense once you look at the patch)? I would like this to be committed before either port so both ports can use this new patch.</font><br>
<font face="Calibri"> </font><br>
<font face="Calibri">-- Johnny</font><br>
</span><font face="Calibri"> [attachment "cmake_get_arch.patch" deleted by Carlo Bertolli/Watson/IBM] </font><br>
<p></p></div>
</blockquote></div></div>