[Openmp-commits] [libc] [openmp] [libc] Change RPC interface to not use device ids (PR #87087)

Joseph Huber via Openmp-commits openmp-commits at lists.llvm.org
Fri Mar 29 10:26:46 PDT 2024


================
@@ -1492,7 +1492,7 @@ Error GenericPluginTy::init() {
   GlobalHandler = createGlobalHandler();
   assert(GlobalHandler && "Invalid global handler");
 
-  RPCServer = new RPCServerTy(NumDevices);
+  RPCServer = new RPCServerTy();
   assert(RPCServer && "Invalid RPC server");
----------------
jhuber6 wrote:

There's a ridiculous amount of  `std::make_unique<T>()`  which we all just assume will not be null. I don't think our library is capable of handling the allocator failing as an expected failure mode. But maybe we could update this in the future. However I think it's out of scope for now.

https://github.com/llvm/llvm-project/pull/87087


More information about the Openmp-commits mailing list