[Openmp-commits] [openmp] [openmp] using h/w clock tick to measure time instead of gettimeofday… (PR #85474)

[David CARLIER via Openmp-commits]

https://github.com/devnexen updated https://github.com/llvm/llvm-project/pull/85474

>From af5b80a6893fae60f7722f322de952c464aa8bbf Mon Sep 17 00:00:00 2001
From: David Carlier <devnexen at gmail.com>
Date: Fri, 15 Mar 2024 22:00:27 +0000
Subject: [PATCH 1/2] [openmp] using h/w clock tick to measure time instead of
 gettimeofday on arm64.

using counter timer frequency register for that purpose, available in user mode.
---
 openmp/runtime/src/kmp_lock.cpp  | 6 +++++-
 openmp/runtime/src/z_Linux_asm.S | 9 +++++++++
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/openmp/runtime/src/kmp_lock.cpp b/openmp/runtime/src/kmp_lock.cpp
index 0ad14f862bcb9b..732a379588ebd3 100644
--- a/openmp/runtime/src/kmp_lock.cpp
+++ b/openmp/runtime/src/kmp_lock.cpp
@@ -2646,10 +2646,14 @@ static void __kmp_set_drdpa_lock_flags(kmp_drdpa_lock_t *lck,
 kmp_backoff_t __kmp_spin_backoff_params = {1, 4096, 100};
 #else
 // Use nanoseconds for other platforms
+#if KMP_ARCH_ARM64
+#define __kmp_tsc() __kmp_hardware_timestamp()
+#else
 extern kmp_uint64 __kmp_now_nsec();
-kmp_backoff_t __kmp_spin_backoff_params = {1, 256, 100};
 #define __kmp_tsc() __kmp_now_nsec()
 #endif
+kmp_backoff_t __kmp_spin_backoff_params = {1, 256, 100};
+#endif
 
 // A useful predicate for dealing with timestamps that may wrap.
 // Is a before b? Since the timestamps may wrap, this is asking whether it's
diff --git a/openmp/runtime/src/z_Linux_asm.S b/openmp/runtime/src/z_Linux_asm.S
index 14987c298fa5f9..af147292599bab 100644
--- a/openmp/runtime/src/z_Linux_asm.S
+++ b/openmp/runtime/src/z_Linux_asm.S
@@ -1360,6 +1360,15 @@ KMP_LABEL(kmp_1):
 	DEBUG_INFO __kmp_invoke_microtask
 // -- End  __kmp_invoke_microtask
 
+// kmp_uint64
+// __kmp_hardware_timestamp(void)
+   PROC __kmp_hardware_timestamp
+   mrs x0, cntfrq_el0
+   mov x30, x0
+   ret
+   DEBUG_INFO __kmp_hardware_timestamp
+// -- End  __kmp_hardware_timestamp
+
 #endif /* (KMP_OS_LINUX || KMP_OS_DARWIN || KMP_OS_WINDOWS) && KMP_ARCH_AARCH64 */
 
 #if (KMP_OS_LINUX || KMP_OS_DARWIN || KMP_OS_WINDOWS) && KMP_ARCH_ARM

>From a5a79938e1f5004e3819b41d80c6464a2d8ed135 Mon Sep 17 00:00:00 2001
From: David Carlier <devnexen at gmail.com>
Date: Sat, 16 Mar 2024 06:57:55 +0000
Subject: [PATCH 2/2] changes from feedback

---
 openmp/runtime/src/kmp_lock.cpp | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/openmp/runtime/src/kmp_lock.cpp b/openmp/runtime/src/kmp_lock.cpp
index 732a379588ebd3..7b201f6fe43332 100644
--- a/openmp/runtime/src/kmp_lock.cpp
+++ b/openmp/runtime/src/kmp_lock.cpp
@@ -2644,14 +2644,13 @@ static void __kmp_set_drdpa_lock_flags(kmp_drdpa_lock_t *lck,
 #define __kmp_tsc() __kmp_hardware_timestamp()
 // Runtime's default backoff parameters
 kmp_backoff_t __kmp_spin_backoff_params = {1, 4096, 100};
-#else
-// Use nanoseconds for other platforms
-#if KMP_ARCH_ARM64
+#elif KMP_ARCH_ARM64
 #define __kmp_tsc() __kmp_hardware_timestamp()
+kmp_backoff_t __kmp_spin_backoff_params = {1, 256, 100};
 #else
+// Use nanoseconds for other platforms
 extern kmp_uint64 __kmp_now_nsec();
 #define __kmp_tsc() __kmp_now_nsec()
-#endif
 kmp_backoff_t __kmp_spin_backoff_params = {1, 256, 100};
 #endif