[Openmp-commits] [openmp] [libomptarget] Support BE ELF files in plugins-nextgen (PR #85246)

Joseph Huber via Openmp-commits openmp-commits at lists.llvm.org
Thu Mar 14 08:34:03 PDT 2024


================
@@ -138,9 +149,10 @@ getSymbolFromSysVHashTable(StringRef Name, const typename ELFT::Hash &HashTab,
 }
 
 template <class ELFT>
-static Expected<const typename ELFT::Sym *>
-getHashTableSymbol(const ELFFile<ELFT> &Elf, const typename ELFT::Shdr &Sec,
-                   StringRef Name) {
+static Expected<std::optional<ELFSymbolRef>>
+getHashTableSymbol(const ELFObjectFile<ELFT> &ELFObj,
+                   const typename ELFT::Shdr &Sec, StringRef Name) {
+  const ELFFile<ELFT> &Elf = ELFObj.getELFFile();
----------------
jhuber6 wrote:

Why is this part changed? It's internal so it should be using the "actual" ELF format and not the Object file wrapper I would assume.

https://github.com/llvm/llvm-project/pull/85246


More information about the Openmp-commits mailing list