[Openmp-commits] [openmp] [openmp][flang] Add tests for map clause (PR #70394)

via Openmp-commits openmp-commits at lists.llvm.org
Fri Oct 27 10:52:20 PDT 2023

agozillon wrote:

Ah both these cases work downstream which is what I tested with then glossed over the xfail and failing directory, that's my bad. 

I'd lean towards open up issues on things and point towards the file that's failing when it's added as a test to the failing directory (and perhaps add the issue number or link as a comment to the failing test, so people can close the issue once it's fixed, i.e. when they see the test fail locally after making changes that fix it and move the test).

Although, for both of these failing cases I'm not sure it's worth generating an issue, the second with implicit capture should work after @TIFitis IsolatedFromAbove patch series and the first should work with the changes added in the array sectioning patch! However, feel free to open up an issue on them if you wish! 


More information about the Openmp-commits mailing list