[Openmp-commits] [openmp] [Libomptarget][NFC] Remove use of VLA in the AMDGPU plugin (PR #69761)

Shilei Tian via Openmp-commits openmp-commits at lists.llvm.org
Fri Oct 20 12:47:52 PDT 2023


================
@@ -2869,15 +2869,14 @@ struct AMDGPUPluginTy final : public GenericPluginTy {
         if (Status != HSA_STATUS_SUCCESS)
           return Status;
 
-        // TODO: This is not allowed by the standard.
-        char ISAName[Length];
-        Status = hsa_isa_get_info_alt(ISA, HSA_ISA_INFO_NAME, ISAName);
+        llvm::SmallVector<char> ISAName(Length);
----------------
shiltian wrote:

Do we need `Length + 1` here? I know it's not there even before.

https://github.com/llvm/llvm-project/pull/69761


More information about the Openmp-commits mailing list