[Openmp-commits] [PATCH] D155621: [OpenMP][libomptarget] Improve plugin resource managers

Ye Luo via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Jul 25 08:49:52 PDT 2023


ye-luo added a comment.

Glad to see more error traps.



================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:173
+  /// The handle to the actual resource.
+  HandleTy Resource;
 };
----------------
Can we use `ResourceTy&` to express a true reference? Why do we need to use pointer to emulate reference which C++ already has.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155621/new/

https://reviews.llvm.org/D155621



More information about the Openmp-commits mailing list