[Openmp-commits] [PATCH] D155621: [OpenMP][libomptarget] Improve plugin resource managers

[Kevin Sala via Phabricator via Openmp-commits]

kevinsala marked an inline comment as done.
kevinsala added inline comments.


================
Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp:1189
     // Consume another stream slot and compute dependencies.
-    std::tie(Curr, InputSignal) = consume(OutputSignal2);
+    std::tie(Curr, InputSignal) = consume(OutputSignals[1]);
     assert(InputSignal && "Invalid input signal");
----------------
jhuber6 wrote:
> Don't need `std::tie` anymore, C++17 structured bindings should work.
I think structured bindings do not allow re-using the variables. To re-use them, I believe we still need `std::tie`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155621/new/

https://reviews.llvm.org/D155621