[Openmp-commits] [PATCH] D127367: [OpenMP] [OMPT] [7/8] Invoke tool-supplied callbacks before and after target launch and data transfer operations

[Michael Halkenhäuser via Phabricator via Openmp-commits]

mhalk updated this revision to Diff 543675.
mhalk added a comment.

Fixed warning related to template deduction -- thanks @jdoerfert
Fixed constant numbers being used in target data operations
NFC / improved naming of InterfaceRAII

Known issue:
Missing test coverage for target region operations: `enter_data`, `exit_data`, `update`
Callback my fire before the actual device init and report wrong device number

- Saw this with `enter_data` when performing a datamapping within a new testcase

Currently, I plan on landing this within the next five hours.
If there are concerns or further feedback, let me know.

*ping* @jdoerfert @dhruvachak


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127367/new/

https://reviews.llvm.org/D127367

Files:
  openmp/libomptarget/include/OmptCallback.h
  openmp/libomptarget/src/OmptCallback.cpp
  openmp/libomptarget/src/OmptInterface.h
  openmp/libomptarget/src/device.cpp
  openmp/libomptarget/src/interface.cpp
  openmp/libomptarget/src/omptarget.cpp
  openmp/libomptarget/test/ompt/veccopy.c
  openmp/libomptarget/test/ompt/veccopy_disallow_both.c
  openmp/libomptarget/test/ompt/veccopy_emi.c
  openmp/libomptarget/test/ompt/veccopy_emi_map.c
  openmp/libomptarget/test/ompt/veccopy_map.c
  openmp/libomptarget/test/ompt/veccopy_no_device_init.c
  openmp/libomptarget/test/ompt/veccopy_wrong_return.c
  openmp/runtime/src/ompt-event-specific.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D127367.543675.patch
Type: text/x-patch
Size: 45615 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20230724/6f8905e4/attachment-0001.bin>