[Openmp-commits] [PATCH] D127367: [OpenMP] [OMPT] [7/8] Invoke tool-supplied callbacks before and after target launch and data transfer operations

[Dhruva Chakrabarti via Phabricator via Openmp-commits]

dhruvachak added inline comments.


================
Comment at: openmp/libomptarget/src/device.cpp:624
+  /// RAII to establish tool anchors before and after data submit
+  OmptInterfaceTargetDataOpRAII TargetDataSubmitRAII(
+      RTLDeviceID, Size, HstPtrBegin, TgtPtrBegin,
----------------
jplehr wrote:
> In the asynchronous case, the lifetime of the RAII object is probably too short to account for the actual data transfer events.
I think the asynchronous case is not an issue for the callbacks. The begin and end callbacks are supposed to be invoked before and after the entry-point invocation. The actual data transfer may complete later and is supposed to be captured by device tracing, something that is not part of this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127367/new/

https://reviews.llvm.org/D127367