[Openmp-commits] [PATCH] D127367: [OpenMP] [OMPT] [7/8] Invoke tool-supplied callbacks before and after target launch and data transfer operations

[Michael Halkenhäuser via Phabricator via Openmp-commits]

mhalk updated this revision to Diff 543565.
mhalk added a comment.

Implemented templated RAII class.

Please, take a look if this is the desired direction.
If the approach should be changed, let me know.

Other than that, there are a few outstanding issues:
(Currently looking into the first two.)

- Warnings are currently emitted for each RAII instance

  warning: 'InterfaceRAII' may not intend to support class template argument
           deduction [-Wctad-maybe-unsupported]
  note: add a deduction guide to suppress this warning



- Test coverage should be expanded for target region operations: `enter_data`, `exit_data`, `update`
  - Those cases are handled by the RAII -- but simply not tested.
  - Will add another lit test in another upcoming review.
- Asynchronous timing does not work correctly as stated in a previous comment. RAII objects will be prematurely destroyed in this use case. Please, let me know if this is a requirement for accepting this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127367/new/

https://reviews.llvm.org/D127367

Files:
  openmp/libomptarget/include/OmptCallback.h
  openmp/libomptarget/src/OmptCallback.cpp
  openmp/libomptarget/src/OmptInterface.h
  openmp/libomptarget/src/device.cpp
  openmp/libomptarget/src/interface.cpp
  openmp/libomptarget/src/omptarget.cpp
  openmp/libomptarget/test/ompt/veccopy.c
  openmp/libomptarget/test/ompt/veccopy_disallow_both.c
  openmp/libomptarget/test/ompt/veccopy_emi.c
  openmp/libomptarget/test/ompt/veccopy_emi_map.c
  openmp/libomptarget/test/ompt/veccopy_map.c
  openmp/libomptarget/test/ompt/veccopy_no_device_init.c
  openmp/libomptarget/test/ompt/veccopy_wrong_return.c
  openmp/runtime/src/ompt-event-specific.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D127367.543565.patch
Type: text/x-patch
Size: 38279 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20230724/735255fa/attachment-0001.bin>