[Openmp-commits] [PATCH] D127367: [OpenMP] [OMPT] [7/8] Invoke tool-supplied callbacks before and after target launch and data transfer operations

[Michael Halkenhäuser via Phabricator via Openmp-commits]

mhalk added inline comments.


================
Comment at: openmp/libomptarget/src/omptarget.cpp:45
+  void endSubmit() {
+    // if (!OmptEnabled) return;
+    RegionInterface.endTargetSubmit(NumTeams);
----------------
mhalk wrote:
> jdoerfert wrote:
> > Commented code?
> Yes, my bad -- as stated in my other comment there are six occurrences, all of which will be removed upon the next change.
> `performIfOmptInitialized` already checks the Variable before calling `[begin|end]Submit()`.
FYI: I' will adapt this "part" of the patch (using an Init flag) upon the landing of D155186.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127367/new/

https://reviews.llvm.org/D127367