[Openmp-commits] [PATCH] D149685: [OpenMP] libomptarget: Don't map alignment padding to host

[Joel E. Denny via Phabricator via Openmp-commits]

jdenny added a comment.

In D149685#4479109 <https://reviews.llvm.org/D149685#4479109>, @cseo wrote:

> OK, thanks! I'll take a look then.

If you want to fix target_derefence_array_pointrs.cpp, I suggest looking at its function `zoo`.  It explicitly maps the pointer `sa` when mapping `*sa` is needed.  Its mapping has memory aliasing between `sa` and `sa->sa`.  I'm not sure what the test intended, and I'm not confident how the implementation is meant to handle those cases, so you might want to contact the test's author.  (It would also be nice to fix the typos in the test name while you're there.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149685/new/

https://reviews.llvm.org/D149685