[Openmp-commits] [PATCH] D149685: [OpenMP] libomptarget: Don't map alignment padding to host

[Carlos Eduardo Seo via Phabricator via Openmp-commits]

cseo added a comment.

In D149685#4474512 <https://reviews.llvm.org/D149685#4474512>, @jdenny wrote:

> In D149685#4471532 <https://reviews.llvm.org/D149685#4471532>, @cseo wrote:
>
>> I think there's a corner case you may have missed. I'm still seeing this on aarch64:
>>
>>   /llvm-project/openmp/libomptarget/test/mapping/target_derefence_array_pointrs.cpp:28:12: error: CHECK: expected string not found in input
>>    // CHECK: 3
>>              ^
>>   <stdin>:1:103: note: scanning from here
>>   Libomptarget message: explicit extension not allowed: host address specified is 0x0000ffffd26ff7c0 (12 bytes), but device allocation maps to host at 0x0000ffffd26ff7c0 (8 bytes)
>>                                                                                                         ^
>>   <stdin>:1:104: note: possible intended match here
>>   Libomptarget message: explicit extension not allowed: host address specified is 0x0000ffffd26ff7c0 (12 bytes), but device allocation maps to host at 0x0000ffffd26ff7c0 (8 bytes)
>>
>> Your patch fixes most failures, except this one. Fails with and without LTO enabled. Could you please check?
>
> I'm not testing on aarch64, but that test fails for me both before and after this patch.  This patch is about padding generated for a partial struct mapping, which is irrelevant to that test, as far as I can tell.

OK, thanks! I'll take a look then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149685/new/

https://reviews.llvm.org/D149685