[Openmp-commits] [PATCH] D124652: [OpenMP] [OMPT] [amdgpu] [5/8] Implemented device init/fini/load callbacks

[Michael Halkenhäuser via Phabricator via Openmp-commits]

mhalk added a comment.

Thank you @jplehr, that is much appreciated.



================
Comment at: openmp/libomptarget/src/OmptCallback.cpp:82
+
+  LibraryFinalizer = new LibomptargetRtlFinalizer();
 
----------------
jplehr wrote:
> Should we assert here that `LibraryFinalizer` is actually `nullptr`, so we would catch any changes in assumptions about how often something is called early?
Yes, I'll add an assert here -- making sure `LibraryFinalizer == nullptr` before creating the object.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124652/new/

https://reviews.llvm.org/D124652