[Openmp-commits] [PATCH] D124652: [OpenMP] [OMPT] [amdgpu] [5/8] Implemented device init/fini/load callbacks

[Jan-Patrick Lehr via Phabricator via Openmp-commits]

jplehr accepted this revision.
jplehr added a comment.
This revision is now accepted and ready to land.

I know you did quite a bit of testing, so I assume this works. Just the one nit.
LGTM



================
Comment at: openmp/libomptarget/src/OmptCallback.cpp:82
+
+  LibraryFinalizer = new LibomptargetRtlFinalizer();
 
----------------
Should we assert here that `LibraryFinalizer` is actually `nullptr`, so we would catch any changes in assumptions about how often something is called early?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124652/new/

https://reviews.llvm.org/D124652