[Openmp-commits] [PATCH] D139208: [OpenMP][libomptarget][AMDGPU] lock/unlock (pin/unpin) mechanism in libomptarget amdgpu plugin (API and implementation)

[Bertolli, Carlo via Openmp-commits]

[AMD Official Use Only - General]

Hi Slava

Yes, that's defined in hsa_ext_amd.h. Not sure why it wasn't picked up in my local build, but I will add it straight away. I am guessing that a push to main branch is fine?

Thanks

-- Carlo

Get Outlook for iOS<https://aka.ms/o0ukef>
________________________________
From: Slava Zakharin via Phabricator <reviews at reviews.llvm.org>
Sent: Friday, January 13, 2023 1:19:40 PM
To: Bertolli, Carlo <Carlo.Bertolli at amd.com>; ronl at codeaurora.org <ronl at codeaurora.org>; jdoerfert at anl.gov <jdoerfert at anl.gov>; i at tianshilei.me <i at tianshilei.me>; xw111luoye at gmail.com <xw111luoye at gmail.com>; greg63706 at gmail.com <greg63706 at gmail.com>; Chakrabarti, Dhruva <Dhruva.Chakrabarti at amd.com>
Cc: szakharin at nvidia.com <szakharin at nvidia.com>; openmp-commits at lists.llvm.org <openmp-commits at lists.llvm.org>; jonathanchesterfield at gmail.com <jonathanchesterfield at gmail.com>; kevin.sala at bsc.es <kevin.sala at bsc.es>; Zhuravlyov, Konstantin <Konstantin.Zhuravlyov at amd.com>; jv356 at scarletmail.rutgers.edu <jv356 at scarletmail.rutgers.edu>; Liu, Yaxun (Sam) <Yaxun.Liu at amd.com>; Stuttard, David <David.Stuttard at amd.com>; zhang.guansong at gmail.com <zhang.guansong at gmail.com>; wei.ding2 at amd.com <wei.ding2 at amd.com>; Kerbow, Austin <Austin.Kerbow at amd.com>; ivan at kosarev.info <ivan at kosarev.info>; stefomeister at gmail.com <stefomeister at gmail.com>; balaji-sankar-naga-sai-sandeep.kosuri at hpe.com <balaji-sankar-naga-sai-sandeep.kosuri at hpe.com>; misono.tomohiro at fujitsu.com <misono.tomohiro at fujitsu.com>; sunil.shrestha at hpe.com <sunil.shrestha at hpe.com>; Pandey, Amit <Amit.Pandey at amd.com>; Balasubrmanian, Vignesh <Vignesh.Balasubrmanian at amd.com>; Kumar N, Bhuvanendra <Bhuvanendra.KumarN at amd.com>; lin32 at llnl.gov <lin32 at llnl.gov>; liao6 at llnl.gov <liao6 at llnl.gov>; abidmuslim at gmail.com <abidmuslim at gmail.com>; sara.royuela at bsc.es <sara.royuela at bsc.es>; Islam, Saiyedul <Saiyedul.Islam at amd.com>; Tomar, Sourabh Singh <SourabhSingh.Tomar at amd.com>; chichun.chen at hpe.com <chichun.chen at hpe.com>; deepak.eachempati at hpe.com <deepak.eachempati at hpe.com>; Lieberman, Ron <Ron.Lieberman at amd.com>; jdenny.ornl at gmail.com <jdenny.ornl at gmail.com>; jatin.bhateja at gmail.com <jatin.bhateja at gmail.com>; ravi.narayanaswamy at intel.com <ravi.narayanaswamy at intel.com>; michael.hliao at gmail.com <michael.hliao at gmail.com>; a.bataev at hotmail.com <a.bataev at hotmail.com>; kannan.narayanan at amd.com <kannan.narayanan at amd.com>; tra at google.com <tra at google.com>; Neubauer, Sebastian <Sebastian.Neubauer at amd.com>; Song, Ruiling <Ruiling.Song at amd.com>; Lambert, Jacob <Jacob.Lambert at amd.com>
Subject: [PATCH] D139208: [OpenMP][libomptarget][AMDGPU] lock/unlock (pin/unpin) mechanism in libomptarget amdgpu plugin (API and implementation)

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


vzakhari added a comment.

Hi @carlo.bertolli, I am getting the following error in my local build after this commit:

  /mybuild/openmp/libomptarget/plugins/amdgpu/impl/impl.cpp:17:3: error: ‘hsa_amd_pointer_info_t’ was not declared in this scope; did you mean ‘hsa_amd_agent_info_t’?
     17 |   hsa_amd_pointer_info_t info;
        |   ^~~~~~~~~~~~~~~~~~~~~~
        |   hsa_amd_agent_info_t

Is there missing definition in `hsa_ext_amd.h`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139208/new/

https://reviews.llvm.org/D139208

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20230113/47d5bd31/attachment-0001.html>