<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
</head>
<body>
<p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;" align="Left">
[AMD Official Use Only - General]<br>
</p>
<br>
<div>
<div dir="ltr">
<div></div>
<div>
<div>
<div dir="ltr"><span id="ms-outlook-ios-cursor"></span>Hi Slava</div>
</div>
<div dir="ltr"><br>
</div>
<div dir="ltr">Yes, that's defined in hsa_ext_amd.h. Not sure why it wasn't picked <span>up in my local build, but I will add it straight away. I am guessing that a push to main branch is fine?</span></div>
<div dir="ltr"><span><br>
</span></div>
<div dir="ltr"><span>Thanks </span></div>
<div dir="ltr"><span><br>
</span></div>
<div dir="ltr"><span>-- Carlo</span></div>
<div dir="ltr"><span><br>
</span></div>
<div id="ms-outlook-mobile-signature">Get <a href="https://aka.ms/o0ukef">Outlook for iOS</a></div>
</div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Slava Zakharin via Phabricator <reviews@reviews.llvm.org><br>
<b>Sent:</b> Friday, January 13, 2023 1:19:40 PM<br>
<b>To:</b> Bertolli, Carlo <Carlo.Bertolli@amd.com>; ronl@codeaurora.org <ronl@codeaurora.org>; jdoerfert@anl.gov <jdoerfert@anl.gov>; i@tianshilei.me <i@tianshilei.me>; xw111luoye@gmail.com <xw111luoye@gmail.com>; greg63706@gmail.com <greg63706@gmail.com>;
Chakrabarti, Dhruva <Dhruva.Chakrabarti@amd.com><br>
<b>Cc:</b> szakharin@nvidia.com <szakharin@nvidia.com>; openmp-commits@lists.llvm.org <openmp-commits@lists.llvm.org>; jonathanchesterfield@gmail.com <jonathanchesterfield@gmail.com>; kevin.sala@bsc.es <kevin.sala@bsc.es>; Zhuravlyov, Konstantin <Konstantin.Zhuravlyov@amd.com>;
jv356@scarletmail.rutgers.edu <jv356@scarletmail.rutgers.edu>; Liu, Yaxun (Sam) <Yaxun.Liu@amd.com>; Stuttard, David <David.Stuttard@amd.com>; zhang.guansong@gmail.com <zhang.guansong@gmail.com>; wei.ding2@amd.com <wei.ding2@amd.com>; Kerbow, Austin <Austin.Kerbow@amd.com>;
ivan@kosarev.info <ivan@kosarev.info>; stefomeister@gmail.com <stefomeister@gmail.com>; balaji-sankar-naga-sai-sandeep.kosuri@hpe.com <balaji-sankar-naga-sai-sandeep.kosuri@hpe.com>; misono.tomohiro@fujitsu.com <misono.tomohiro@fujitsu.com>; sunil.shrestha@hpe.com
<sunil.shrestha@hpe.com>; Pandey, Amit <Amit.Pandey@amd.com>; Balasubrmanian, Vignesh <Vignesh.Balasubrmanian@amd.com>; Kumar N, Bhuvanendra <Bhuvanendra.KumarN@amd.com>; lin32@llnl.gov <lin32@llnl.gov>; liao6@llnl.gov <liao6@llnl.gov>; abidmuslim@gmail.com
<abidmuslim@gmail.com>; sara.royuela@bsc.es <sara.royuela@bsc.es>; Islam, Saiyedul <Saiyedul.Islam@amd.com>; Tomar, Sourabh Singh <SourabhSingh.Tomar@amd.com>; chichun.chen@hpe.com <chichun.chen@hpe.com>; deepak.eachempati@hpe.com <deepak.eachempati@hpe.com>;
Lieberman, Ron <Ron.Lieberman@amd.com>; jdenny.ornl@gmail.com <jdenny.ornl@gmail.com>; jatin.bhateja@gmail.com <jatin.bhateja@gmail.com>; ravi.narayanaswamy@intel.com <ravi.narayanaswamy@intel.com>; michael.hliao@gmail.com <michael.hliao@gmail.com>; a.bataev@hotmail.com
<a.bataev@hotmail.com>; kannan.narayanan@amd.com <kannan.narayanan@amd.com>; tra@google.com <tra@google.com>; Neubauer, Sebastian <Sebastian.Neubauer@amd.com>; Song, Ruiling <Ruiling.Song@amd.com>; Lambert, Jacob <Jacob.Lambert@amd.com><br>
<b>Subject:</b> [PATCH] D139208: [OpenMP][libomptarget][AMDGPU] lock/unlock (pin/unpin) mechanism in libomptarget amdgpu plugin (API and implementation)</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.<br>
<br>
<br>
vzakhari added a comment.<br>
<br>
Hi @carlo.bertolli, I am getting the following error in my local build after this commit:<br>
<br>
/mybuild/openmp/libomptarget/plugins/amdgpu/impl/impl.cpp:17:3: error: ‘hsa_amd_pointer_info_t’ was not declared in this scope; did you mean ‘hsa_amd_agent_info_t’?<br>
17 | hsa_amd_pointer_info_t info;<br>
| ^~~~~~~~~~~~~~~~~~~~~~<br>
| hsa_amd_agent_info_t<br>
<br>
Is there missing definition in `hsa_ext_amd.h`?<br>
<br>
<br>
Repository:<br>
rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
<a href="https://reviews.llvm.org/D139208/new/">https://reviews.llvm.org/D139208/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D139208">https://reviews.llvm.org/D139208</a><br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>