[Openmp-commits] [PATCH] D157918: [Libomptarget] Support mapping indirect host calls to device functions

Ravi Narayanaswamy via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Aug 14 15:11:09 PDT 2023


RaviNarayanaswamy added inline comments.


================
Comment at: openmp/libomptarget/DeviceRTL/src/Misc.cpp:84
+
+  if (!Table || TableSize == 0)
+    return nullptr;
----------------
jhuber6 wrote:
> RaviNarayanaswamy wrote:
> > Do you want to check  if HstPtr is null  then return nullptr
> Yeah that's a good idea.
Also if the Table does  not exist or size zero return the same pointer since it might already be a device pointer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157918/new/

https://reviews.llvm.org/D157918



More information about the Openmp-commits mailing list