[Openmp-commits] [PATCH] D157918: [Libomptarget] Support mapping indirect host calls to device functions

[Ravi Narayanaswamy via Phabricator via Openmp-commits]

RaviNarayanaswamy added inline comments.


================
Comment at: openmp/libomptarget/include/omptarget.h:95
+  /// Mark the entry global as being an indirectly callable function.
+  OMP_DECLARE_TARGET_INDIRECT = 0x04
 };
----------------
jhuber6 wrote:
> RaviNarayanaswamy wrote:
> > Should this be 0x08
> I didn't design it this way, but the frontend uses different flags for globals and kernels. All the other flags overlap so why should this one be the exception without breaking ABI and redesigning it?
You want the lookup table to be  small.  Does TARGET_DTOR get added to the indirect lookup  table?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157918/new/

https://reviews.llvm.org/D157918