[Openmp-commits] [PATCH] D134565: [OpenMP][Offload] Initial patch for Level Zero plugin

[Shilei Tian via Phabricator via Openmp-commits]

tianshilei1992 added a comment.

We currently have a new plugin interface https://reviews.llvm.org/D134396, and the use of `libelf` is expected to go away.



================
Comment at: openmp/libomptarget/cmake/Modules/LibomptargetGetDependencies.cmake:268
+  # Search L0 library
+  if(WIN32)
+    if(CMAKE_SIZEOF_VOID_P EQUAL 8)
----------------
LLVM OpenMP doesn't support Windows. Do we want to keep the condition here?


================
Comment at: openmp/libomptarget/cmake/Modules/LibomptargetGetDependencies.cmake:285
+    PATH_SUFFIXES
+      lib/ubuntu_18.04 lib) # TODO: follow up with path changes
+
----------------
Yeah, better to fix the suffix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134565/new/

https://reviews.llvm.org/D134565