[Openmp-commits] [PATCH] D134396: [OpenMP][libomptarget] New plugin infrastructure and new CUDA plugin

Kevin Sala Penad├ęs via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Fri Sep 23 12:21:44 PDT 2022


kevinsala added inline comments.


================
Comment at: openmp/libomptarget/plugins-nextgen/cuda/dynamic_cuda/cuda.cpp:117
+      const char *First = It->second;
+      void *P = dlsym(DynlibHandle, First);
+      if (P) {
----------------
jhuber6 wrote:
> We use LLVM's dynamic library handling for this now, refer to `dynamic_cuda.cpp`
Maybe we can reuse the same file from the original plugin so we don't need to apply fixes to both files.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134396/new/

https://reviews.llvm.org/D134396



More information about the Openmp-commits mailing list