[Openmp-commits] [PATCH] D134275: [OpenMP] [OMPD] Build gdb-plugin code only when python3 development files are available.

[Aaron Puchert via Phabricator via Openmp-commits]

aaronpuchert added inline comments.


================
Comment at: openmp/libompd/CMakeLists.txt:11-17
+set(LIBOMP_OMPD_GDB_SUPPORT FALSE CACHE BOOL
+        "Build gdb-plugin code that enables OMPD support in GDB.")
+
+find_package (Python3 COMPONENTS Interpreter Development)
+if (Python3_INCLUDE_DIRS AND Python3_LIBRARIES)
+    set(LIBOMP_OMPD_GDB_SUPPORT TRUE)
+endif()
----------------
Use `Python3_FOUND` (see [docs](https://cmake.org/cmake/help/latest/module/FindPython3.html#result-variables)).


================
Comment at: openmp/libompd/gdb-plugin/CMakeLists.txt:16
 
 find_package (Python3 COMPONENTS Interpreter Development)
 
----------------
This should no longer be necessary if the parent directory finds it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134275/new/

https://reviews.llvm.org/D134275