[Openmp-commits] [PATCH] D133997: [Libomptarget] Revert changes to AMDGPU plugin destructors

Joseph Huber via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Sep 15 17:22:45 PDT 2022

jhuber6 created this revision.
jhuber6 added reviewers: jdoerfert, tianshilei1992, ye-luo, JonChesterfield, ronlieb, gregrodgers.
Herald added subscribers: kosarev, kerbowa, t-tye, tpr, dstuttard, yaxunl, jvesely, kzhuravl.
Herald added a project: All.
jhuber6 requested review of this revision.
Herald added subscribers: openmp-commits, wdng.
Herald added a project: OpenMP.

These patches exposed a lot of problems in the AMD toolchain. Rather
than keep it broken we should revert it to its old semi-functional
state. This will prevent us from using device destructors but should
remove some new bugs. In the future this interface should be changed
once these problems are addressed more correctly.

This reverts commit ed0f21811544320f829124efbb6a38ee12eb9155 <https://reviews.llvm.org/rGed0f21811544320f829124efbb6a38ee12eb9155>.

This reverts commit 2b7203a35972e98b8521f92d2791043dc539ae88 <https://reviews.llvm.org/rG2b7203a35972e98b8521f92d2791043dc539ae88>.

Fixes #57536

  rG LLVM Github Monorepo



-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133997.460564.patch
Type: text/x-patch
Size: 6092 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20220916/c4021cce/attachment.bin>

More information about the Openmp-commits mailing list