[Openmp-commits] [PATCH] D133655: [OpenMP][libomptarget] Add mutex to safely read/modify HostPinnedAllocs map

Joseph Huber via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Sep 14 10:23:19 PDT 2022


jhuber6 added a comment.

In D133655#3785490 <https://reviews.llvm.org/D133655#3785490>, @kevinsala wrote:

> In D133655#3785431 <https://reviews.llvm.org/D133655#3785431>, @jhuber6 wrote:
>
>> Is this solving an immediate error you're experiencing? If not we should wait for a consensus on removing this map entirely, otherwise if it's urgent we could probably land this temporarily.
>
> No, actually I didn't experience any error related to it. I was debugging something else and saw this concurrent access not being protected. Thus, it's not a problem to wait for a consensus on removing the map.

I landed D133655 <https://reviews.llvm.org/D133655> which removes this map entirely, thanks for the patch regardless.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133655/new/

https://reviews.llvm.org/D133655



More information about the Openmp-commits mailing list