[Openmp-commits] [PATCH] D133655: [OpenMP][libomptarget] Add mutex to safely read/modify HostPinnedAllocs map

Joseph Huber via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Sat Sep 10 19:32:34 PDT 2022

jhuber6 added a comment.

In D133655#3782570 <https://reviews.llvm.org/D133655#3782570>, @tianshilei1992 wrote:

> In D133655#3782567 <https://reviews.llvm.org/D133655#3782567>, @jhuber6 wrote:
>> I have a review up that removes this map entirely, for this and other reasons D133053 <https://reviews.llvm.org/D133053>. The review seemed to have stalled as @tianshilei1992 had concerns about changing the interface and what that meant for backwards compatibility.
> Yeah, we still didn't make the consensus we need.

There was a user-visible change where `omp_target_free` didn't work anymore for the special allocation types, but that was against the standard anyway. Then there was the plugin change. The issue was changing the plugin interface right? I could still just introduce a new one that is called by the old one, but if we remove backwards compatibility it would be much easier all around.

  rG LLVM Github Monorepo



More information about the Openmp-commits mailing list