[Openmp-commits] [PATCH] D133594: [Libomptarget] Fix compiling with asserts using the bitcode library

[Joseph Huber via Phabricator via Openmp-commits]

jhuber6 added a comment.

In D133594#3781111 <https://reviews.llvm.org/D133594#3781111>, @JonChesterfield wrote:

> It seems a bit sketchy to be defining libc symbols in the openmp runtime.  Is there a reason we can't prefix these __omp or similar?

Because `assert` is expanded to `__assert_fail` by the preprocessor, so we just provide that function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133594/new/

https://reviews.llvm.org/D133594