[Openmp-commits] [PATCH] D138689: [openmp] Support building for armv7 Windows with mingw tools

[David Spickett via Phabricator via Openmp-commits]

DavidSpickett added a comment.

> (The version in z_Linux_util.cpp only handles up to 15 arguments. And contrary to aarch64, z_Linux_asm.S doesn't have any assembly for 32 bit arm.)

So this means that simply extending it to handle 17 arguments wouldn't help because it would want to use the assembly version of the other functions?



================
Comment at: openmp/runtime/src/kmp_atomic.cpp:866
 
-#endif // KMP_OS_WINDOWS && KMP_ARCH_AARCH64
+#endif // KMP_OS_WINDOWS && (KMP_ARCH_AARCH64 || KMP_ARCH_ARM)
 
----------------
Is the `!` correct here?


================
Comment at: openmp/runtime/src/z_Windows_NT_util.cpp:81
 KMP_BUILD_ASSERT(offsetof(SYSTEM_THREAD, KernelTime) == 0);
-#if KMP_ARCH_X86
+#if KMP_ARCH_X86 || KMP_ARCH_ARM
 KMP_BUILD_ASSERT(offsetof(SYSTEM_THREAD, StartAddress) == 28);
----------------
Does X86 mean 32 bit here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138689/new/

https://reviews.llvm.org/D138689