[Openmp-commits] [PATCH] D138689: [openmp] Support building for armv7 Windows with mingw tools

Martin Storsjö via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Nov 24 13:57:20 PST 2022


mstorsjo created this revision.
mstorsjo added reviewers: AndreyChurbanov, JonChesterfield, natgla, jdoerfert, Meinersbur, DavidSpickett.
Herald added subscribers: guansong, kristof.beyls, yaxunl.
Herald added a project: All.
mstorsjo requested review of this revision.
Herald added a subscriber: sstefan1.
Herald added a project: OpenMP.

This does things in the same way as
D137168 <https://reviews.llvm.org/D137168> / a356782426f5bf54a00570e1f925345e5fda7b2e <https://reviews.llvm.org/rGa356782426f5bf54a00570e1f925345e5fda7b2e> and
D101173 <https://reviews.llvm.org/D101173> / 4fb0aaf03381473ec8af727edb4b5d59b64b0d60 <https://reviews.llvm.org/rG4fb0aaf03381473ec8af727edb4b5d59b64b0d60> did for aarch64.

This adds a C implementation of __kmp_invoke_microtask in the same
way as the fallback C implementation in z_Linux_util.cpp - however
this one handles up to 17 arguments, which makes
test/misc_bugs/many-microtask-args.c pass. (The version in
z_Linux_util.cpp only handles up to 15 arguments. And contrary to
aarch64, z_Linux_asm.S doesn't have any assembly for 32 bit arm.)

This passes all tests (with D137748 <https://reviews.llvm.org/D137748> and D137772 <https://reviews.llvm.org/D137772> applied).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D138689

Files:
  openmp/runtime/src/kmp.h
  openmp/runtime/src/kmp_atomic.cpp
  openmp/runtime/src/kmp_os.h
  openmp/runtime/src/kmp_platform.h
  openmp/runtime/src/z_Windows_NT-586_util.cpp
  openmp/runtime/src/z_Windows_NT_util.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138689.477845.patch
Type: text/x-patch
Size: 7720 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20221124/f5dcf82b/attachment-0001.bin>


More information about the Openmp-commits mailing list